Re: [PATCH] staging: fbtft: remove unnecessary braces in if statements and space before close parenthesis in function call

From: Greg KH
Date: Wed Jul 24 2024 - 09:55:34 EST


On Wed, Jul 24, 2024 at 06:22:55PM +0530, Riyan Dhiman wrote:
> Hi,
>
> Thank you for your feedback on my patch submission.
> I understand that the fix provided by my patch is not needed. As this is my
> first contribution to the Linux kernel, I am eager to learn and make
> valuable contributions.
> To ensure my future submissions are more aligned with the needs, I would
> like to know if it would be helpful for me to focus on the following types
> of fixes:
>
> - CHECK: usleep_range is preferred over udelay; see
> Documentation/timers/timers-howto.rst

That's very hard to fix without access to the device and the knowledge
of what needs to happen. See the archives for where people have tried
to do this and the responses they got.

> - WARNING: Unnecessary ftrace-like logging - prefer using ftrace

That's good to clean up, try that and see!

thanks,
g
reg k-h