Re: get_maintainer.pl finds old email address not in MAINTAINERS

[Joe Perches]

On Wed, 2024-07-24 at 15:25 +0200, Paul Menzel wrote:
> Dear Linux folks,
> 
> 
> I sent a patch [1] using
> 
>      git send-email --identity=linux 
> 0001-USB-core-hub_port_reset-Remove-extra-40-ms-reset-rec.patch
> 
> with the git configuration below.
> 
>      [sendemail.linux]
>      	tocmd ="`pwd`/scripts/get_maintainer.pl --nogit --nogit-fallback 
> --norolestats --nol"
>       	cccmd ="`pwd`/scripts/get_maintainer.pl --nogit --nogit-fallback 
> --norolestats --nom"
> 
> That resulted in Gregs old SUSE address getting added:
> 
>      $ git describe origin
>      v6.10-12246-g786c8248dbd3
>      $ scripts/get_maintainer.pl --nogit --nogit-fallback --norolestats 
> --nom 0001-USB-core-hub_port_reset-Remove-extra-40-ms-reset-rec.patch
>      Greg Kroah-Hartman <gregkh@xxxxxxx>
>      David Brownell <david-b@xxxxxxxxxxx>
>      linux-usb@xxxxxxxxxxxxxxx
>      linux-kernel@xxxxxxxxxxxxxxx
> 
> I am wondering where that address is coming from, and if I should change 
> my git configuration?

It's coming from the commit of the Fixes: line

Fixes: b789696af8b4 ("[PATCH] USB: relax usbcore reset timings")

And that commit has those email addresses.

I suppose it could be argued that the existing .mailmap entry
should somehow fix this but without changing .mailmap entries
with just a single email address like this:

diff --git a/.mailmap b/.mailmap
index 8284692f9610..1d2062d479b9 100644
--- a/.mailmap
+++ b/.mailmap
@@ -204,7 +204,7 @@ Gerald Schaefer <gerald.schaefer@xxxxxxxxxxxxx> <geraldsc@xxxxxxxxxx>
 Gerald Schaefer <gerald.schaefer@xxxxxxxxxxxxx> <gerald.schaefer@xxxxxxxxxx>
 Gerald Schaefer <gerald.schaefer@xxxxxxxxxxxxx> <geraldsc@xxxxxxxxxxxxxxxxxx>
 Greg Kroah-Hartman <greg@echidna.(none)>
-Greg Kroah-Hartman <gregkh@xxxxxxx>
+Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> <gregkh@xxxxxxx>
 Greg Kroah-Hartman <greg@xxxxxxxxx>
 Greg Kurz <groug@xxxxxxxx> <gkurz@xxxxxxxxxxxxxxxxxx>
 Gregory CLEMENT <gregory.clement@xxxxxxxxxxx> <gregory.clement@xxxxxxxxxxxxxxxxxx>

There's no trivial way to do that.

If these single line entries in .mailmap are modified,
get_maintainer works fine.

Here's the Fixes: commit:

---
commit b789696af8b4102b7cc26dec30c2c51ce51ee18b
Author: David Brownell <david-b@xxxxxxxxxxx>
Date:   Wed Aug 31 10:41:44 2005 -0700

    [PATCH] USB: relax usbcore reset timings
    
    This appears to help some folk, please merge.
    This patch relaxes reset timings.  There are some reports that it
    helps make enumeration work better on some high speed devices.
    
    Signed-off-by: David Brownell <dbrownell@xxxxxxxxxxxxxxxxxxxxx>
    Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxx>