Re: [PATCH v5 0/8] mmc: sdhci-of-dwcmshc: Add Sophgo SG2042 support

[Chen Wang]

On 2024/7/25 5:09, Drew Fustini wrote:
> On Fri, Jul 19, 2024 at 04:44:38PM +0800, Chen Wang wrote:
> > From: Chen Wang <unicorn_wang@xxxxxxxxxxx>
> >
> > This patchset is composed of two parts:
> > - one is the improvement of the sdhci-of-dwcmshc framework,
> > - the other is the support for sg2042 based on the improvement of the
> >    framework.
> > The reason for merging the two parts into one patchset is mainly to
> > facilitate review, especially to facilitate viewing why we need to
> > improve the framework and what benefits it will bring to us.
> >
> > When I tried to add a new soc(SG2042) to sdhci-of-dwcmshc, I found
> > that the existing driver code could be optimized to facilitate expansion
> > for the new soc. Patch 1 ~ Patch 5 is for this.
> >
> > Patch 6 ~ 7 are adding support for the mmc controller for Sophgo SG2042.
> > Adding corresponding new compatible strings, and implement
> > custom callbacks for SG2042 based on new framework.
> >
> > Patch 8 is the change for DTS.
> >
> > By the way, although I believe this patch only optimizes the framework
> > of the code and does not change the specific logic, simple verification
> > is certainly better. Since I don't have rk35xx/th1520 related hardware,
> > it would be greatly appreciated if someone could help verify it.
> > Note, the DTS change has dependency on clock changes for SG2042, which
> > has not been merged in master/upstream, so if you want to test this
> > new sdhci-of-dwcmshc driver for other hardware except SG2042, don't
> > pick patch 8.
> I have tested this on the LicheePi 4a and found no issues.
>
> Tested-by: Drew Fustini <drew@xxxxxxxx> # TH1520
>
> -Drew

Thank you Drew，you are always the best! :)

Regards,

Chen