Re: [PATCH v2 4/4] usb: typec: ucsi: Fix SET_PDR typo in UCSI header file

From: Dmitry Baryshkov
Date: Wed Jul 24 2024 - 23:51:29 EST


On Wed, Jul 24, 2024 at 08:11:16PM GMT, Jameson Thies wrote:
> Fix SET_PDR typo in UCSI header file.
>
> Reviewed-by: Neil Armstrong <neil.armstrong@xxxxxxxxxx>
> Signed-off-by: Jameson Thies <jthies@xxxxxxxxxx>
> ---
> Changes in V2:
> - None.

Fixes: 470ce43a1a81 ("usb: typec: ucsi: Remove struct ucsi_control")

Note, fixes patches should come before the rest of the changes.

>
> drivers/usb/typec/ucsi/ucsi.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/typec/ucsi/ucsi.h b/drivers/usb/typec/ucsi/ucsi.h
> index 6a958eac5703..a0e91335da80 100644
> --- a/drivers/usb/typec/ucsi/ucsi.h
> +++ b/drivers/usb/typec/ucsi/ucsi.h
> @@ -153,7 +153,7 @@ void ucsi_connector_change(struct ucsi *ucsi, u8 num);
> #define UCSI_SET_UOR_ROLE(_r_) (((_r_) == TYPEC_HOST ? 1 : 2) << 23)
> #define UCSI_SET_UOR_ACCEPT_ROLE_SWAPS BIT(25)
>
> -/* SET_PDF command bits */
> +/* SET_PDR command bits */
> #define UCSI_SET_PDR_ROLE(_r_) (((_r_) == TYPEC_SOURCE ? 1 : 2) << 23)
> #define UCSI_SET_PDR_ACCEPT_ROLE_SWAPS BIT(25)
>
> --
> 2.45.2.1089.g2a221341d9-goog
>

--
With best wishes
Dmitry