Re: [PATCH 2/2] lib/test_bits.c: Add tests for GENMASK_U128()

From: Anshuman Khandual
Date: Thu Jul 25 2024 - 00:20:26 EST




On 7/25/24 06:34, kernel test robot wrote:
> Hi Anshuman,
>
> kernel test robot noticed the following build errors:
>
> [auto build test ERROR on arnd-asm-generic/master]
> [also build test ERROR on akpm-mm/mm-nonmm-unstable akpm-mm/mm-everything linus/master v6.10 next-20240724]
> [If your patch is applied to the wrong git tree, kindly drop us a note.
> And when submitting patch, we suggest to use '--base' as documented in
> https://git-scm.com/docs/git-format-patch#_base_tree_information]
>
> url: https://github.com/intel-lab-lkp/linux/commits/Anshuman-Khandual/uapi-Define-GENMASK_U128/20240724-184809
> base: https://git.kernel.org/pub/scm/linux/kernel/git/arnd/asm-generic.git master
> patch link: https://lore.kernel.org/r/20240724103142.165693-3-anshuman.khandual%40arm.com
> patch subject: [PATCH 2/2] lib/test_bits.c: Add tests for GENMASK_U128()
> config: m68k-sun3x_defconfig (https://download.01.org/0day-ci/archive/20240725/202407250853.f3pSzob6-lkp@xxxxxxxxx/config)
> compiler: m68k-linux-gcc (GCC) 14.1.0
> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240725/202407250853.f3pSzob6-lkp@xxxxxxxxx/reproduce)
>
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@xxxxxxxxx>
> | Closes: https://lore.kernel.org/oe-kbuild-all/202407250853.f3pSzob6-lkp@xxxxxxxxx/
>
> All errors (new ones prefixed by >>):
>
> In file included from lib/test_bits.c:6:
> lib/test_bits.c: In function 'genmask_u128_test':
>>> include/uapi/linux/const.h:24:36: error: '__int128' is not supported on this target
> 24 | #define _AC128(X) ((unsigned __int128)(X))
> | ^~~~~~~~
> include/kunit/test.h:708:22: note: in definition of macro 'KUNIT_BASE_BINARY_ASSERTION'
> 708 | const typeof(right) __right = (right); \
> | ^~~~~
> include/kunit/test.h:903:9: note: in expansion of macro 'KUNIT_BINARY_INT_ASSERTION'
> 903 | KUNIT_BINARY_INT_ASSERTION(test, \
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~
> include/kunit/test.h:900:9: note: in expansion of macro 'KUNIT_EXPECT_EQ_MSG'
> 900 | KUNIT_EXPECT_EQ_MSG(test, left, right, NULL)
> | ^~~~~~~~~~~~~~~~~~~
> lib/test_bits.c:45:9: note: in expansion of macro 'KUNIT_EXPECT_EQ'
> 45 | KUNIT_EXPECT_EQ(test, 0x0000000000ff0000ULL, GENMASK_U128(87, 80) >> 64);
> | ^~~~~~~~~~~~~~~
> include/uapi/linux/const.h:29:26: note: in expansion of macro '_AC128'
> 29 | #define _U128(x) (_AC128(x))
> | ^~~~~~
> include/uapi/linux/bits.h:16:13: note: in expansion of macro '_U128'
> 16 | (((~_U128(0)) - (_U128(1) << (l)) + 1) & \
> | ^~~~~
> include/linux/bits.h:39:38: note: in expansion of macro '__GENMASK_U128'
> 39 | (GENMASK_INPUT_CHECK(h, l) + __GENMASK_U128(h, l))
> | ^~~~~~~~~~~~~~
> lib/test_bits.c:45:54: note: in expansion of macro 'GENMASK_U128'
> 45 | KUNIT_EXPECT_EQ(test, 0x0000000000ff0000ULL, GENMASK_U128(87, 80) >> 64);

This is probably triggered with GENMASK_U128() usage which is not protected
with ARCH_SUPPORTS_INT128. Will respin the series with required fixes.