Re: [PATCH] dt-bindings: PCI: qcom: Allow 'vddpe-3v3-supply' again

[Johan Hovold]

On Wed, Jul 24, 2024 at 08:22:54PM +0300, Dmitry Baryshkov wrote:
> On Tue, Jul 23, 2024 at 05:13:28PM GMT, Johan Hovold wrote:
> > Commit 756485bfbb85 ("dt-bindings: PCI: qcom,pcie-sc7280: Move SC7280 to
> > dedicated schema") incorrectly removed 'vddpe-3v3-supply' from the
> > bindings, which results in DT checker warnings like:
> > 
> > 	arch/arm64/boot/dts/qcom/msm8996-sony-xperia-tone-dora.dtb: pcie@600000: Unevaluated properties are not allowed ('vddpe-3v3-supply' was unexpected)
> >         from schema $id: http://devicetree.org/schemas/pci/qcom,pcie.yaml#
> > 
> > Note that this property has been part of the Qualcomm PCIe bindings
> > since 2018 and would need to be deprecated rather than simply removed if
> > there is a desire to replace it with 'vpcie3v3' which is used for some
> > non-Qualcomm controllers.
> 
> I think Rob Herring suggested [1] adding the property to the root port
> node rather than the host. If that suggestion still applies it might be
> better to enable the deprecated propertly only for the hosts, which
> already used it, and to define a new property at the root port.

You seem to miss the point that this is just restoring status quo (and
that the property has not yet been deprecated).

I assume you've already read my reply to Rob's bot, but here it is for
reference for others:

Link: https://lore.kernel.org/lkml/Zp_LPixNnh-2Fy5N@xxxxxxxxxxxxxxxxxxxx/	

Johan