Re: [PATCH 1/2] dt-bindings: display: Add Sharp Memory LCD bindings

From: Krzysztof Kozlowski
Date: Thu Jul 25 2024 - 02:18:55 EST


On 25/07/2024 02:47, Alex Lanzano wrote:
> Add device tree bindings for the monochrome Sharp Memory LCD
>
> Signed-off-by: Alex Lanzano <lanzano.alex@xxxxxxxxx>
> ---
> .../bindings/display/sharp,sharp-memory.yaml | 97 +++++++++++++++++++
> include/dt-bindings/display/sharp-memory.h | 9 ++
> 2 files changed, 106 insertions(+)

BTW, look at your original binding:
https://lore.kernel.org/dri-devel/2a7c51b6e619c02ec175a5c219b0a0fd7a24499d.1701267411.git.mehdi.djait@xxxxxxxxxxx/

Why did you decide to introduce mistakes? Eg. dropping all $refs?

And finally look at the comment:
https://lore.kernel.org/dri-devel/5dbdf7bd-cfa3-492b-a0a3-fdc323cf11f8@xxxxxxxxxx/
You just ignored it completely....

Best regards,
Krzysztof