Re: [PATCH bpf v5] bpf: Fixed segment issue when downgrade gso_size

[Daniel Borkmann]

On 7/24/24 3:37 PM, Fred Li wrote:
> > > Linearize skb when downgrad gso_size to prevent triggering
> > > the BUG_ON during segment skb as described in [1].
> > >
> > > v5 changes:
> > >   - add bpf subject prefix.
> > >   - adjust message to imperative mood.
> > >
> > > v4 changes:
> > >   - add fixed tag.
> > >
> > > v3 changes:
> > >   - linearize skb if having frag_list as Willem de Bruijn suggested [2].
> > >
> > > [1] https://lore.kernel.org/all/20240626065555.35460-2-dracodingfly@xxxxxxxxx/
> > > [2] https://lore.kernel.org/all/668d5cf1ec330_1c18c32947@xxxxxxxxxxxxxxxxxxxxxx.notmuch/
> > >
> > > Fixes: 2be7e212d541 ("bpf: add bpf_skb_adjust_room helper")
> > > Signed-off-by: Fred Li <dracodingfly@xxxxxxxxx>
> >
> > Reviewed-by: Willem de Bruijn <willemb@xxxxxxxxxx>
> >
> > My comments were informational, for a next patch if any, really. v4
> > was fine. v5 is too.
>
> Thanks for your advise.
>
> Fred Li

lgtm, I slightly improved wording & applied, thanks!