Re: [PATCH net] macvlan: Return error on register_netdevice_notifier() failure

[Paolo Abeni]

On 7/25/24 11:44, Eric Dumazet wrote:
> On Wed, Jul 24, 2024 at 3:56 PM Shigeru Yoshida <syoshida@xxxxxxxxxx> wrote:
> > register_netdevice_notifier() may fail, but macvlan_init_module() does
> > not handle the failure.  Handle the failure by returning an error.
>
> How could this fail exactly ? Please provide details, because I do not
> think it can.

Yup, it looks like the registration can't fail for macvlan.

It's better to avoid adding unneeded checks, to reduce noise on the 
tree, keep stable backport easy, etc.

Thanks,

Paolo