Re: [PATCH] tracing: remove tracing_is_on export

[Steven Rostedt]

On Thu, 25 Jul 2024 11:36:08 +0200
Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> wrote:

> The function tracing_is_on() is only called by in-kernel code, not by
> any modules, so no need to export it as a symbol at all.

Hmm, this is part of the debugging code along with:

 tracing_on();  tracing_off();

I had it exported in case a module needed to use it in debugging.

-- Steve


> 
> Cc: Steven Rostedt <rostedt@xxxxxxxxxxx>
> Cc: Masami Hiramatsu <mhiramat@xxxxxxxxxx>
> Cc: Mathieu Desnoyers <mathieu.desnoyers@xxxxxxxxxxxx>
> Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
> ---
>  kernel/trace/trace.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c
> index 578a49ff5c32..d09f2effa7a9 100644
> --- a/kernel/trace/trace.c
> +++ b/kernel/trace/trace.c
> @@ -1612,7 +1612,6 @@ int tracing_is_on(void)
>  {
>  	return tracer_tracing_is_on(&global_trace);
>  }
> -EXPORT_SYMBOL_GPL(tracing_is_on);
>  
>  static int __init set_buf_size(char *str)
>  {