Re: [PATCH] ALSA: hda: conexant: Fix headset auto detect fail in the polling mode

[Takashi Iwai]

On Thu, 25 Jul 2024 10:26:10 +0200,
soxiebing wrote:
> 
> From: songxiebing <songxiebing@xxxxxxxxxx>
> 
> 'Fixes: 7aeb25908648 ("Fix headset auto detect fail in cx8070 and SN6140")'

The Fixes tag should be put around Signed-off-by.
Also drop the quote ''.

> This patch only handles the unsol_event reporting during interrupts
> and does not include the polling mode used to set jackroll_ms, so
> it's changed to use snd_hda_jack_detect-enable_callback function.

If you mean about the commit above as "this patch", better to
rephrase to be clearer.

The code change itself looks good, through a quick glance.

Could you try to improve the patch description and resubmit?


thanks,

Takashi