Re: [PATCH v7 0/4] ADP5585 GPIO expander, PWM and keypad controller support

[Lee Jones]

On Mon, 22 Jul 2024, Laurent Pinchart wrote:

> Hello,
> 
> This patch series introduces support for the Analog Devices ADP5585, a
> GPIO expander, PWM and keyboard controller. It models the chip as an MFD
> device, and includes DT bindings (1/4), an MFD driver (2/4) and drivers
> for the GPIO (3/4) and PWM (4/4) functions.
> 
> Support for the keypad controller is left out, as I have no means to
> test it at the moment. The chip also includes a tiny reset controller,
> as well as a 3-bit input programmable logic block, which I haven't tried
> to support (and also have no means to test).
> 
> The driver is based on an initial version from the NXP BSP kernel, then
> extensively and nearly completely rewritten, with added DT bindings. I
> have nonetheless retained original authorship. Clark, Haibo, if you
> would prefer not being credited and/or listed as authors, please let me
> know.
> 
> Compared to v6, this version addresses small review comments. I believe
> it is ready to go, as the PWM and GPIO drivers have been acked by the
> respective subsystem maintainers, and I have addressed Lee's comments on
> the MFD side. Lee, if there's no more issue, could you apply this to
> your tree for v6.12 ?
> 
> Clark Wang (1):
>   pwm: adp5585: Add Analog Devices ADP5585 support
> 
> Haibo Chen (2):
>   mfd: adp5585: Add Analog Devices ADP5585 core support
>   gpio: adp5585: Add Analog Devices ADP5585 support
> 
> Laurent Pinchart (1):
>   dt-bindings: mfd: Add Analog Devices ADP5585
> 
>  .../devicetree/bindings/mfd/adi,adp5585.yaml  |  92 +++++++
>  .../devicetree/bindings/trivial-devices.yaml  |   4 -
>  MAINTAINERS                                   |  11 +
>  drivers/gpio/Kconfig                          |   7 +
>  drivers/gpio/Makefile                         |   1 +
>  drivers/gpio/gpio-adp5585.c                   | 229 ++++++++++++++++++
>  drivers/mfd/Kconfig                           |  12 +
>  drivers/mfd/Makefile                          |   1 +
>  drivers/mfd/adp5585.c                         | 205 ++++++++++++++++
>  drivers/pwm/Kconfig                           |   7 +
>  drivers/pwm/Makefile                          |   1 +
>  drivers/pwm/pwm-adp5585.c                     | 184 ++++++++++++++
>  include/linux/mfd/adp5585.h                   | 126 ++++++++++
>  13 files changed, 876 insertions(+), 4 deletions(-)
>  create mode 100644 Documentation/devicetree/bindings/mfd/adi,adp5585.yaml
>  create mode 100644 drivers/gpio/gpio-adp5585.c
>  create mode 100644 drivers/mfd/adp5585.c
>  create mode 100644 drivers/pwm/pwm-adp5585.c
>  create mode 100644 include/linux/mfd/adp5585.h

Note to self: This looks good to go.  Merge after -rc1 is released.

-- 
Lee Jones [李琼斯]