Re: [PATCH 3/4] f2fs: atomic: fix to truncate pagecache before on-disk metadata truncation

From: Jaegeuk Kim
Date: Thu Jul 25 2024 - 16:54:27 EST


On 06/25, Chao Yu wrote:
> We should always truncate pagecache while truncating on-disk data.
>
> Fixes: a46bebd502fe ("f2fs: synchronize atomic write aborts")
> Signed-off-by: Chao Yu <chao@xxxxxxxxxx>
> ---
> fs/f2fs/file.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c
> index 2203904383a6..0355cb054521 100644
> --- a/fs/f2fs/file.c
> +++ b/fs/f2fs/file.c
> @@ -2185,6 +2185,7 @@ static int f2fs_ioc_start_atomic_write(struct file *filp, bool truncate)
> clear_inode_flag(fi->cow_inode, FI_INLINE_DATA);
> } else {
> /* Reuse the already created COW inode */
> + truncate_setsize(inode, 0);

fi->cow_inode?

> ret = f2fs_do_truncate_blocks(fi->cow_inode, 0, true);
> if (ret) {
> f2fs_up_write(&fi->i_gc_rwsem[WRITE]);
> --
> 2.40.1