Re: [PATCH v7 3/3] hwmon: (adt7475) Add support for configuring initial PWM state

From: Guenter Roeck
Date: Thu Jul 25 2024 - 18:01:52 EST


On 7/25/24 14:02, Chris Packham wrote:

On 26/07/24 02:09, Guenter Roeck wrote:
On Tue, Jul 23, 2024 at 10:17:37AM +1200, Chris Packham wrote:
By default the PWM duty cycle in hardware is 100%. On some systems this
can cause unwanted fan noise. Add the ability to specify the fan
connections and initial state of the PWMs via device properties.

Signed-off-by: Chris Packham <chris.packham@xxxxxxxxxxxxxxxxxxx>
CHECK: Blank lines aren't necessary before a close brace '}'
#207: FILE: drivers/hwmon/adt7475.c:1734:
+
+}

Never mind, applied after fixing the above.

Hmm, odd checkpatch.pl doesn't complain for me


This is a CHECK message. You did not use --strict.

Guenter

$ ./scripts/checkpatch.pl
patches/adt-init-duty/v7/v7-0003-hwmon-adt7475-Add-support-for-configuring-initial.patch

total: 0 errors, 0 warnings, 149 lines checked

patches/adt-init-duty/v7/v7-0003-hwmon-adt7475-Add-support-for-configuring-initial.patch
has no obvious style problems and is ready for submission.


Thanks,
Guenter