Re: [PATCH 1/3] rust: Introduce irq module

[Greg KH]

On Thu, Jul 25, 2024 at 06:27:50PM -0400, Lyude Paul wrote:
> +unsigned long rust_helper_local_irq_save(void) {

Nit, the '{' goes on the next line for a function declaration in C.
checkpatch.pl should have caught this, right?

> +	unsigned long flags;
> +
> +	local_irq_save(flags);
> +
> +	return flags;
> +}
> +EXPORT_SYMBOL_GPL(rust_helper_local_irq_save);
> +
> +void rust_helper_local_irq_restore(unsigned long flags) {

Same here.

thanks,

greg k-h