RE: [PATCH] Drivers: hv: vmbus: Deferring per cpu tasks

From: Dexuan Cui
Date: Fri Jul 26 2024 - 02:02:36 EST


> From: Saurabh Singh Sengar <ssengar@xxxxxxxxxxxxxxxxxxx>
> Sent: Thursday, July 25, 2024 10:27 PM
> [...]
> > > + ret = __cpuhp_setup_state_cpuslocked(CPUHP_AP_ONLINE_DYN,
> > > "hyperv/vmbus:online", false,
> > > + hv_synic_init, hv_synic_cleanup,
> > > false);
> > > + cpus_read_unlock();
> >
> > Add an empty line here to make it slightly more readable? :-)
>
> My personal preference was to have empty line as well here, but then I
> looked the
> other places in this file where we used cpus_read_unlock, hence I
> maintained that style consistent.
>
> Please let me know if you have strong opinion about this empty line, I can
> add in V2.
>
> - Saurabh

I have no strong opinion here :-)