Re: [PATCH] clk: qcom: camcc-sc8280xp: Remove always-on GDSC hard-coding

From: Satya Priya Kakitapalli (Temp)
Date: Fri Jul 26 2024 - 03:01:48 EST



On 7/23/2024 2:59 PM, Bryan O'Donoghue wrote:
On 22/07/2024 09:57, Satya Priya Kakitapalli (Temp) wrote:
I have no idea. Why does it matter ?


This clock expected to be kept always ON, as per design, or else the GDSC transition form ON to OFF (vice versa) wont work.

Yes, parking to XO per this patch works for me. So I guess its already on and is left in that state by the park.

Want to know the clock status after bootup, to understand if the clock got turned off during the late init. May I know exactly what you have tested? Did you test the camera usecases as well?

Of course.

The camera works on x13s with this patch. That's what I mean by tested.


It might be working in your case, but it is not the HW design recommended way to do. The same should not be propagated to other target's camcc drivers, as I already observed it is not working on SM8150.


---
bod