Re: [PATCH] ALSA: hda: conexant: Fix headset auto detect fail in the polling mode

[Takashi Iwai]

On Fri, 26 Jul 2024 03:23:42 +0200,
soxiebing wrote:
> 
> From: songxiebing <songxiebing@xxxxxxxxxx>
> 
> This patch(7aeb25908648) only handles the unsol_event reporting during

It should be rather "The previous fix (7aeb25908648)".  "This" points
the very patch you send now :)

> interrupts and does not include the polling mode used to set jackroll_ms,
> so now we are replacing it with snd_hda_jack_detect_enable_callback.
> 
> Fixes: 7aeb25908648 ("Fix headset auto detect fail in cx8070 and SN6140")

Don't drop "ALSA: hda/conexant:" prefix but copy the full subject line.

> Co-developed-by: bo liu <bo.liu@xxxxxxxxxxxxxx>

Usually Co-developed-by is followed by a Signed-off-by of that
author.

> Signed-off-by: songxiebing <songxiebing@xxxxxxxxxx>

And, I noticed a typo in the patch that broke the compilation:

> -static void cx_update_headset_mic_vref(struct hda_codec *codec, unsigned int res)
> +static void cx_update_headset_mic_vref(struct hda_codec *codec, struct hda_jack_callback *event)
>  {
> -	unsigned int phone_present, mic_persent, phone_tag, mic_tag;
> -	struct conexant_spec *spec = codec->spec;
> +	unsigned int mic_persent;

... here.

Please make sure that the patch really works before submission.
Also, run scripts/checkpatch.pl for checking the coding style and the
patch formalities.


thanks,

Takashi