Re: [PATCH] net: axienet: start napi before enabling Rx/Tx

From: Eric Dumazet
Date: Fri Jul 26 2024 - 03:42:18 EST


On Fri, Jul 26, 2024 at 9:06 AM Andy Chiu <andy.chiu@xxxxxxxxxx> wrote:
>
> softirq may get lost if an Rx interrupt comes before we call
> napi_enable. Move napi_enable in front of axienet_setoptions(), which
> turns on the device, to address the issue.
>
> Link: https://lists.gnu.org/archive/html/qemu-devel/2024-07/msg06160.html
> Fixes: cc37610caaf8 ("net: axienet: implement NAPI and GRO receive")
> Signed-off-by: Andy Chiu <andy.chiu@xxxxxxxxxx>

SGTM, although the axienet_setoptions name is a bit confusing...

Reviewed-by: Eric Dumazet <edumazet@xxxxxxxxxx>