Re: [PATCH v1 06/10] dt-bindings: arm: aspeed: Add aspeed,ast2700-evb compatible string

From: Krzysztof Kozlowski
Date: Fri Jul 26 2024 - 07:15:40 EST


On 26/07/2024 13:03, Kevin Chen wrote:
> ---
> Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml b/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml
> index 71c31c08a8ad..b21551817f44 100644
> --- a/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml
> +++ b/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml
> @@ -99,4 +99,9 @@ properties:
> - ufispace,ncplite-bmc
> - const: aspeed,ast2600
>
> + - description: AST2700 based boards
> + items:
> + - enum:
> + - aspeed,ast2700-evb

NAK, this cannot be alone. Look at all other examples. Why are you doing
things differently?

Best regards,
Krzysztof