Re: [PATCH printk v3 02/19] printk: nbcon: Consolidate alloc() and init()

From: Petr Mladek
Date: Fri Jul 26 2024 - 07:58:53 EST


On Mon 2024-07-22 19:25:22, John Ogness wrote:
> Rather than splitting the nbcon allocation and initialization into
> two pieces, perform all initialization in nbcon_alloc(). Later,
> the init_seq is calculated and can be explicitly set using
> nbcon_seq_force(). This removes the need for the strong rules of
> nbcon_init() that even included a BUG_ON(). It also more closely
> matches the setup logic of the legacy consoles.
>
> Signed-off-by: John Ogness <john.ogness@xxxxxxxxxxxxx>

I like this.

Reviewed-by: Petr Mladek <pmladek@xxxxxxxx>

Best Regards,
Petr