Re: [PATCH] tracing: remove tracing_is_on export

From: Steven Rostedt
Date: Fri Jul 26 2024 - 10:22:17 EST


On Fri, 26 Jul 2024 10:15:14 +0200
Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> wrote:

> > This has been exported since 2008. Has it ever been a problem in the last
> > 16 years?
>
> As I am finding out, yes, external modules are "abusing" this to do
> different types of logic depending on if tracing is enabled or not for
> various unknown reasons. As there was no in-kernel user of this symbol,
> I assumed it was just an oversight and should be removed.
>
> I'll go ask the distro involved to just remove the symbol from their
> kernels instead, but that feels like the wrong thing to do to me.

Interesting as I was unaware of this. I'm not against removing the
"is_on" from being exported, as that really was only there to be
consistent with the others.

-- Steve