Re: [PATCH] staging: media: omap4iss: add check for media_pad_remote_pad_first

From: Dan Carpenter
Date: Fri Jul 26 2024 - 12:05:49 EST


On Fri, Jul 26, 2024 at 03:28:14PM +0800, Chen Ni wrote:
> Add check for the return value of media_pad_remote_pad_first() and
> return the error if it fails in order to avoid NULL pointer dereference.
>
> Fixes: b2e44430b634 ("media: mc-entity: Rename media_entity_remote_pad() to media_pad_remote_pad_first()")

That Fixes tag isn't correct. The patch just renamed the function.

When I look at that patch, the isp_pipeline_is_last() function doesn't
check for NULL either. Why is that one different?

regards,
dan carpenter