Re: [PATCH 3/3] selftests: lib: remove test_bitmap

[Shuah Khan]

On 7/26/24 05:06, Muhammad Usama Anjum wrote:
> Remove the test_bitmap as it has been converted to kunit test.

Care to give some commit information on this change?
This change will take the ability away to run bitmap tests during
boot - as it will now be dependent on kunit

Why are we making changing like this without thinking through?

> Cc: kees@xxxxxxxxxx
> Signed-off-by: Muhammad Usama Anjum <usama.anjum@xxxxxxxxxxxxx>
> ---
>   tools/testing/selftests/lib/Makefile  | 2 +-
>   tools/testing/selftests/lib/bitmap.sh | 3 ---
>   tools/testing/selftests/lib/config    | 1 -
>   3 files changed, 1 insertion(+), 5 deletions(-)
>   delete mode 100755 tools/testing/selftests/lib/bitmap.sh
>
> diff --git a/tools/testing/selftests/lib/Makefile b/tools/testing/selftests/lib/Makefile
> index ee71fc99d5b51..386c5887c0d65 100644
> --- a/tools/testing/selftests/lib/Makefile
> +++ b/tools/testing/selftests/lib/Makefile
> @@ -4,6 +4,6 @@
>   # No binaries, but make sure arg-less "make" doesn't trigger "run_tests"
>   all:
>   
> -TEST_PROGS := printf.sh bitmap.sh prime_numbers.sh scanf.sh strscpy.sh
> +TEST_PROGS := printf.sh prime_numbers.sh scanf.sh strscpy.sh
>   
>   include ../lib.mk
> diff --git a/tools/testing/selftests/lib/bitmap.sh b/tools/testing/selftests/lib/bitmap.sh
> deleted file mode 100755
> index 00a416fbc0ef0..0000000000000
> --- a/tools/testing/selftests/lib/bitmap.sh
> +++ /dev/null
> @@ -1,3 +0,0 @@
> -#!/bin/sh
> -# SPDX-License-Identifier: GPL-2.0
> -$(dirname $0)/../kselftest/module.sh "bitmap" test_bitmap
> diff --git a/tools/testing/selftests/lib/config b/tools/testing/selftests/lib/config
> index 645839b50b0a2..7d3b1de29d3d6 100644
> --- a/tools/testing/selftests/lib/config
> +++ b/tools/testing/selftests/lib/config
> @@ -1,6 +1,5 @@
>   CONFIG_TEST_PRINTF=m
>   CONFIG_TEST_SCANF=m
> -CONFIG_TEST_BITMAP=m
>   CONFIG_PRIME_NUMBERS=m
>   CONFIG_TEST_STRSCPY=m
>   CONFIG_TEST_BITOPS=m

thanks,
-- Shuah