arm64: allow installing compressed image by default
From: Sedat Dilek
Date: Fri Jul 26 2024 - 15:44:26 EST
Hi Linus,
COMPRESSED_INSTALL sounds not very meaningful.
What about ... ?
diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig
index ae527d1d409f..d9f771c788d7 100644
--- a/arch/arm64/Kconfig
+++ b/arch/arm64/Kconfig
@@ -2337,8 +2337,8 @@ config EFI
allow the kernel to be booted as an EFI application. This
is only useful on systems that have UEFI firmware.
-config COMPRESSED_INSTALL
- bool "Install compressed image by default"
+config KERNEL_IMAGE_COMPRESSED_INSTALL
+ bool "Install compressed kernel image by default"
help
This makes the regular "make install" install the compressed
image we built, not the legacy uncompressed one.
diff --git a/arch/arm64/Makefile b/arch/arm64/Makefile
index f6bc3da1ef11..1d9b4978eb98 100644
--- a/arch/arm64/Makefile
+++ b/arch/arm64/Makefile
@@ -182,7 +182,7 @@ $(BOOT_TARGETS): vmlinux
Image.%: Image
$(Q)$(MAKE) $(build)=$(boot) $(boot)/$@
-ifeq ($(CONFIG_COMPRESSED_INSTALL),y)
+ifeq ($(CONFIG_KERNEL_IMAGE_COMPRESSED_INSTALL),y)
DEFAULT_KBUILD_IMAGE = $(KBUILD_IMAGE)
else
DEFAULT_KBUILD_IMAGE = $(boot)/Image
@@ -235,8 +235,8 @@ define archhelp
echo '* Image.gz - Compressed kernel image (arch/$(ARCH)/boot/Image.gz)'
echo ' Image - Uncompressed kernel image (arch/$(ARCH)/boot/Image)'
echo ' image.fit - Flat Image Tree (arch/$(ARCH)/boot/image.fit)'
- echo ' install - Install kernel (compressed if
COMPRESSED_INSTALL set)'
- echo ' zinstall - Install compressed kernel'
+ echo ' install - Install kernel image (compressed if
KERNEL_IMAGE_COMPRESSED_INSTALL is set)'
+ echo ' zinstall - Install compressed kernel image'
echo ' Install using (your) ~/bin/installkernel or'
echo ' (distribution) /sbin/installkernel or'
echo ' install to $$(INSTALL_PATH) and run lilo
I would have renamed KBUILD_IMAGE to KERNEL_IMAGE but other archs use the first.
Thanks.
Best regards,
-Sedat-
P.S.: Attached as patch in the case when GMail will truncate above snippet.
From 6de96573f909345744d63e3a5f5940a78241b2af Mon Sep 17 00:00:00 2001
From: Sedat Dilek <sedat.dilek@xxxxxxxxx>
Date: Fri, 26 Jul 2024 21:37:00 +0200
Subject: [PATCH] arm64: Rename to KERNEL_IMAGE_COMPRESSED_INSTALL kconfig for
compressed kernel image
The COMPRESSED_INSTALL does not sound very meaningful.
Rename from COMPRESSED_INSTALL kconfig to KERNEL_IMAGE_COMPRESSED_INSTALL.
Fixes: commit 4c7be57f2 ("arm64: allow installing compressed image by default")
Cc: Catalin Marinas <catalin.marinas@xxxxxxx>
Acked-by: Will Deacon <will@xxxxxxxxxx>
Signed-off-by: Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx>
Signed-off-by: Sedat Dilek <sedat.dilek@xxxxxxxxx>
---
arch/arm64/Kconfig | 4 ++--
arch/arm64/Makefile | 6 +++---
2 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig
index ae527d1d409f..d9f771c788d7 100644
--- a/arch/arm64/Kconfig
+++ b/arch/arm64/Kconfig
@@ -2337,8 +2337,8 @@ config EFI
allow the kernel to be booted as an EFI application. This
is only useful on systems that have UEFI firmware.
-config COMPRESSED_INSTALL
- bool "Install compressed image by default"
+config KERNEL_IMAGE_COMPRESSED_INSTALL
+ bool "Install compressed kernel image by default"
help
This makes the regular "make install" install the compressed
image we built, not the legacy uncompressed one.
diff --git a/arch/arm64/Makefile b/arch/arm64/Makefile
index f6bc3da1ef11..1d9b4978eb98 100644
--- a/arch/arm64/Makefile
+++ b/arch/arm64/Makefile
@@ -182,7 +182,7 @@ $(BOOT_TARGETS): vmlinux
Image.%: Image
$(Q)$(MAKE) $(build)=$(boot) $(boot)/$@
-ifeq ($(CONFIG_COMPRESSED_INSTALL),y)
+ifeq ($(CONFIG_KERNEL_IMAGE_COMPRESSED_INSTALL),y)
DEFAULT_KBUILD_IMAGE = $(KBUILD_IMAGE)
else
DEFAULT_KBUILD_IMAGE = $(boot)/Image
@@ -235,8 +235,8 @@ define archhelp
echo '* Image.gz - Compressed kernel image (arch/$(ARCH)/boot/Image.gz)'
echo ' Image - Uncompressed kernel image (arch/$(ARCH)/boot/Image)'
echo ' image.fit - Flat Image Tree (arch/$(ARCH)/boot/image.fit)'
- echo ' install - Install kernel (compressed if COMPRESSED_INSTALL set)'
- echo ' zinstall - Install compressed kernel'
+ echo ' install - Install kernel image (compressed if KERNEL_IMAGE_COMPRESSED_INSTALL is set)'
+ echo ' zinstall - Install compressed kernel image'
echo ' Install using (your) ~/bin/installkernel or'
echo ' (distribution) /sbin/installkernel or'
echo ' install to $$(INSTALL_PATH) and run lilo'
--
2.45.2