Re: [PATCH 0/7] minmax: reduce compilation time
From: Linus Torvalds
Date: Fri Jul 26 2024 - 18:49:21 EST
On Fri, 26 Jul 2024 at 14:36, Linus Torvalds
<torvalds@xxxxxxxxxxxxxxxxxxx> wrote:
>
> LOL. At least some of that is because of 'pageblock_order', which
> expands to 2.5kB of text [..]
Ok, I pushed out my two fixes - one for the xen/setup.c case, and
another for the ridiculous 'pageblock_order' expansion.
They both looked obvious to me, and they definitely make for a notably
smaller preprocessor noise load, but maybe I messed something up.
I didn't even look at what the issue was with the
bio_for_each_segment() expansion, in the hope that Jens will make that
one look better.
There are probably many other cases where we have these kinds of "tens
of kB of macro expansion", I only looked at the xen case and the
mm/compaction.c case based on Lorenzo's list of top offenders.
Linus