Re: [syzbot] [f2fs?] WARNING in rcu_sync_dtor

[Hillf Danton]

On Fri, 26 Jul 2024 00:54:21 -0700
> syzbot found the following issue on:
> 
> HEAD commit:    1722389b0d86 Merge tag 'net-6.11-rc1' of git://git.kernel...
> git tree:       upstream
> C reproducer:   https://syzkaller.appspot.com/x/repro.c?x=115edac9980000

#syz test upstream  1722389b0d86

--- x/fs/f2fs/super.c
+++ y/fs/f2fs/super.c
@@ -4169,16 +4169,7 @@ void f2fs_handle_critical_error(struct f
 	 */
 	if (continue_fs || f2fs_readonly(sb) || shutdown) {
 		f2fs_warn(sbi, "Stopped filesystem due to reason: %d", reason);
-		return;
 	}
-
-	f2fs_warn(sbi, "Remounting filesystem read-only");
-	/*
-	 * Make sure updated value of ->s_mount_flags will be visible before
-	 * ->s_flags update
-	 */
-	smp_wmb();
-	sb->s_flags |= SB_RDONLY;
 }
 
 static void f2fs_record_error_work(struct work_struct *work)
--