Re: [PATCH] Drivers: hv: vmbus: Deferring per cpu tasks

From: Srivatsa S. Bhat
Date: Sat Jul 27 2024 - 08:53:42 EST


On Fri, Jul 26, 2024 at 04:26:19AM -0700, Saurabh Singh Sengar wrote:
> On Fri, Jul 26, 2024 at 06:34:53AM +0000, Srivatsa S. Bhat wrote:
> > On Fri, Jul 26, 2024 at 12:01:33AM +0000, Dexuan Cui wrote:
> > > > From: Saurabh Singh Sengar <ssengar@xxxxxxxxxxxxxxxxxxx>
> > > > Sent: Thursday, July 25, 2024 8:35 AM
> > > > Subject: Re: [PATCH] Drivers: hv: vmbus: Deferring per cpu tasks
> > >
> > > Without the patch, I think the current CPU uses IPIs to let the other
> > > CPUs, one by one, run the function calls, and synchronously waits
> > > for the function calls to finish.
> > >
> > > IMO the patch is not "Deferring per cpu tasks". "Defer" means "let it
> > > happen later". Here it schedules work items to different CPUs, and
> > > the work items immediately start to run on these CPUs.
> > >
> > > I would suggest a more accurate subject:
> > > Drivers: hv: vmbus: Run hv_synic_init() concurrently
> > >
> >
> > It would be great to call out the "why" as well in the title,
> > something like:
> >
> > Drivers: hv: vmbus: Speed-up booting by running hv_synic_init() concurrently
>
> Thanks, I can also rephrase it like below if sounds fine to you:
>
> Drivers: hv: vmbus: Optimize boot time by concurrent execution of hv_synic_init()
>

Sure, that sounds good too.

Regards,
Srivatsa
Microsoft Linux Systems Group