Re: [PATCH v5 7/9] iio: adc: stm32-dfsdm: adopt generic channels bindings

[Jonathan Cameron]

On Wed, 24 Jul 2024 17:36:35 +0200
Olivier Moysan <olivier.moysan@xxxxxxxxxxx> wrote:

> Move to generic channels binding to ease new backend framework adoption
> and prepare the convergence with MDF IP support on STM32MP2 SoC family.
> 
> Legacy binding:
> DFSDM is an IIO channel consumer.
> SD modulator is an IIO channels provider.
> The channel phandles are provided in DT through io-channels property
> and channel indexes through st,adc-channels property.
> 
> New binding:
> DFSDM is an IIO channel provider.
> The channel indexes are given by reg property in channel child node.
> 
> This new binding is intended to be used with SD modulator IIO backends.
> It does not support SD modulator legacy IIO devices.
> The st,adc-channels property presence is used to discriminate
> between legacy and backend bindings.
> 
> The support of the DFSDM legacy channels and SD modulator IIO devices
> is kept for backward compatibility.
> 
> Signed-off-by: Olivier Moysan <olivier.moysan@xxxxxxxxxxx>
Hi Olivier,

At some point it would be good to use dev_err_probe() though out all the
probe only paths.
It might save you quite a few lines of code and print nicer error messages.

Otherwise LGTM

Thanks,

Jonathan