Re: [PATCH v2 1/1] hwmon: (asus-ec-sensors) remove VRM temp X570-E GAMING

[Guenter Roeck]

On Sat, Jul 27, 2024 at 07:04:52PM +0200, Eugene Shalygin wrote:
> From: RobotRoss <true.robot.ross@xxxxxxxxx>
> 
> There is no hardware support, it seems the sensor was added by mistake [1].
> 
> [1] https://github.com/zeule/asus-ec-sensors/pull/58
> 
Such a reference in an upstream git log has little if any value since it
may be deleted at some point. On top of that "it seems the sensor was
added by mistake" doesn't really add value either.

"X570-E GAMING does not support the VRM temperature sensor."

would have been good enough.

> Signed-off-by: RobotRoss <true.robot.ross@xxxxxxxxx>

Hmm, that very much looks like an alias.

Guenter

> Signed-off-by: Eugene Shalygin <eugene.shalygin@xxxxxxxxx>
> ---
>  drivers/hwmon/asus-ec-sensors.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/hwmon/asus-ec-sensors.c b/drivers/hwmon/asus-ec-sensors.c
> index 6bb8d7b1d219..ee396f21fac5 100644
> --- a/drivers/hwmon/asus-ec-sensors.c
> +++ b/drivers/hwmon/asus-ec-sensors.c
> @@ -420,7 +420,7 @@ static const struct ec_board_info board_info_strix_b550_i_gaming = {
>  
>  static const struct ec_board_info board_info_strix_x570_e_gaming = {
>  	.sensors = SENSOR_SET_TEMP_CHIPSET_CPU_MB |
> -		SENSOR_TEMP_T_SENSOR | SENSOR_TEMP_VRM |
> +		SENSOR_TEMP_T_SENSOR |
>  		SENSOR_FAN_CHIPSET | SENSOR_CURR_CPU |
>  		SENSOR_IN_CPU_CORE,
>  	.mutex_path = ASUS_HW_ACCESS_MUTEX_ASMX,
> -- 
> 2.45.2
> 
>