Re: [RFC PATCH net-next v6 03/14] af_vsock: support multi-transport datagrams

From: Arseniy Krasnov
Date: Sun Jul 28 2024 - 16:40:59 EST


Hi Amery

> /* Transport features flags */
> /* Transport provides host->guest communication */
> -#define VSOCK_TRANSPORT_F_H2G 0x00000001
> +#define VSOCK_TRANSPORT_F_H2G 0x00000001
> /* Transport provides guest->host communication */
> -#define VSOCK_TRANSPORT_F_G2H 0x00000002
> -/* Transport provides DGRAM communication */
> -#define VSOCK_TRANSPORT_F_DGRAM 0x00000004
> +#define VSOCK_TRANSPORT_F_G2H 0x00000002
> +/* Transport provides fallback for DGRAM communication */
> +#define VSOCK_TRANSPORT_F_DGRAM_FALLBACK 0x00000004
> /* Transport provides local (loopback) communication */
> -#define VSOCK_TRANSPORT_F_LOCAL 0x00000008
> +#define VSOCK_TRANSPORT_F_LOCAL 0x00000008

^^^ This is refactoring ?


> + /* During vsock_create(), the transport cannot be decided yet if
> + * using virtio. While for VMCI, it is transport_dgram_fallback.


I'm not English speaker, but 'decided' -> 'detected'/'resolved' ?



Thanks, Arseniy