Re: [PATCH] irqchip/gic-v3: Remove asmlinkage for gic_handle_irq()
From: Jinjie Ruan
Date: Sun Jul 28 2024 - 22:37:17 EST
On 2024/7/27 17:25, Thomas Gleixner wrote:
> On Sat, Jul 27 2024 at 15:36, Jinjie Ruan wrote:
>> Since commit 064dbfb41691 ("arm64: entry: convert IRQ+FIQ handlers to C"),
>> the gic_handle_irq() is only called by C functions, so remove
>> the asmlinkage.
>>
>> Fixes: 064dbfb41691 ("arm64: entry: convert IRQ+FIQ handlers to C")
>> Signed-off-by: Jinjie Ruan <ruanjinjie@xxxxxxxxxx>
>
> Right. Can we please fix all of that and be done with it?
>
> # git grep -l asmlinkage drivers/irqchip/ | xargs grep set_handle_irq
>
> should find the remaining leftovers of asmlinkage.
You are right,handle_arch_irq() are all only called in C now, we can all
remove the asmlinkage.
>
> Thanks,
>
> tglx