Re: [v4] arm64: Rename to KERNEL_IMAGE_COMPRESSED_INSTALL kconfig for compressed kernel image
From: Anshuman Khandual
Date: Sun Jul 28 2024 - 22:46:54 EST
On 7/28/24 01:27, Will Deacon wrote:
> On Fri, Jul 26, 2024 at 10:09:30PM +0200, Sedat Dilek wrote:
>> The COMPRESSED_INSTALL kconfig does not sound very meaningful.
>>
>> Rename from COMPRESSED_INSTALL kconfig to KERNEL_IMAGE_COMPRESSED_INSTALL.
>>
>> Fixes: commit 4c7be57f2 ("arm64: allow installing compressed image by default")
"Fixes:" tag should only be used for patches that fix real functional
problems in the code.
>> Signed-off-by: Sedat Dilek <sedat.dilek@xxxxxxxxx>
>> ---
>> arch/arm64/Kconfig | 6 +++---
>> arch/arm64/Makefile | 6 +++---
>> 2 files changed, 6 insertions(+), 6 deletions(-)
>
> Hmm, I'm not sure I see the point of this tbh. I think the code is fine
> as it is.
Agreed, only thing this patch does is to add "kernel image" prefix
in the config as well in related descriptions which in itself does
not make this any better. As Will mentioned, it is better to leave
this unchanged.