Re: [PATCH] MAINTAINERS: Add entry for Samsung Exynos850 SoC
From: Krzysztof Kozlowski
Date: Mon Jul 29 2024 - 02:28:20 EST
On 26/07/2024 18:08, Alim Akhtar wrote:
>
>
>> -----Original Message-----
>> From: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
>> Sent: Friday, July 26, 2024 8:47 PM
>> To: Sam Protsenko <semen.protsenko@xxxxxxxxxx>
>> Cc: Alim Akhtar <alim.akhtar@xxxxxxxxxxx>; Peter Griffin
>> <peter.griffin@xxxxxxxxxx>; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; linux-
>> samsung-soc@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; Chanwoo Choi
>> <cw00.choi@xxxxxxxxxxx>; Marek Szyprowski
>> <m.szyprowski@xxxxxxxxxxx>; Peter Griffin <peter.griffin@xxxxxxxxxx>;
>> Jaewon Kim <jaewon02.kim@xxxxxxxxxxx>; Mateusz Majewski
>> <m.majewski2@xxxxxxxxxxx>; Henrik Grimler <henrik@xxxxxxxxxx>; David
>> Virag <virag.david003@xxxxxxxxx>; Artur Weber <aweber.kernel@xxxxxxxxx>;
>> Raymond Hackley <raymondhackley@xxxxxxxxxxxxxx>
>> Subject: Re: [PATCH] MAINTAINERS: Add entry for Samsung Exynos850 SoC
>>
>> On 30/01/2024 08:29, Krzysztof Kozlowski wrote:
>>> On 29/01/2024 21:47, Sam Protsenko wrote:
>>>> Add maintainers entry for the Samsung Exynos850 SoC based platforms.
>>>>
>>>> Signed-off-by: Sam Protsenko <semen.protsenko@xxxxxxxxxx>
>>>> ---
>>>> MAINTAINERS | 10 ++++++++++
>>>> 1 file changed, 10 insertions(+)
>>>>
>>>> diff --git a/MAINTAINERS b/MAINTAINERS index
>>>> 939f6dd0ef6a..77c10cc669f8 100644
>>>> --- a/MAINTAINERS
>>>> +++ b/MAINTAINERS
>>>> @@ -19281,6 +19281,16 @@ B: mailto:linux-samsung-
>> soc@xxxxxxxxxxxxxxx
>>>> F: Documentation/devicetree/bindings/sound/samsung*
>>>> F: sound/soc/samsung/
>>>>
>>>> +SAMSUNG EXYNOS850 SoC SUPPORT
>>>> +M: Sam Protsenko <semen.protsenko@xxxxxxxxxx>
>>>> +L: linux-arm-kernel@xxxxxxxxxxxxxxxxxxx (moderated for non-subscribers)
>>>> +L: linux-samsung-soc@xxxxxxxxxxxxxxx
>>>
>>> Sorry, but I am still against individual SoC entries in maintainers,
>>> like I replied multiple times and pointed to the updated
>>> get_maintainers.pl script to fetch emails from boards.
>>
>> I retract my earlier statement.
>>
>> Some background: I was really hoping that scripts/get_maintainers.pl patch,
>> which adds fetching emails from files (e.g. DTS), will be picked up, but it has
>> been few years, few resends and there is no conclusion. I don't think it will be
>> ever merged, thus this email.
>>
>> Since C files do not have in-file "maintainer" entry and particular drivers have
>> MAINTAINERS-file entries, then why DTS should be different?
>>
> Not sure what was the discussion in past, do you think this need some discussion in LPC?
>
>> I'll take the patch after merge window.
>>
>> +Cc few other folks,
>>
>> I understand that with lei/lore filters one can easily track patches sent for
>> particular boards or SoCs, but being listed in MAINTAINERS have a bit bigger
>> meaning. Therefore if any of you consider / want to add themself to
>> MAINTAINERS for particular DTS, then go ahead. By DTS I
>> mean: particular boards (e.g. Galaxy Tab 3 family) or particular SoC (e.g.
>> Exynos850 like here).
>>
> Actually it is being confusing. Completely agreed that "MAINTAINERS have a bit bigger".
> By adding each DTS/SoC/Board MAINTAINERS entry, are those members expected to send pull requests?
> If so, that leads to more confusion and overhead.
No, just like maintainers of drivers do not send them. The way of
handling patches won't change.
Best regards,
Krzysztof