Re: [PATCH v5 1/2] drm/loongson: Introduce component framework support

From: Markus Elfring
Date: Mon Jul 29 2024 - 02:41:27 EST



> +++ b/drivers/gpu/drm/loongson/loongson_drv.h
> @@ -0,0 +1,108 @@

> +#ifndef __LOONGSON_DRV_H__
> +#define __LOONGSON_DRV_H__


I suggest to omit leading underscores from such identifiers.
https://wiki.sei.cmu.edu/confluence/display/c/DCL37-C.+Do+not+declare+or+define+a+reserved+identifier

Regards,
Markus