Re: [PATCH 1/5] dt-bindings: clock: mt6765: Add missing PMIC clock

From: Krzysztof Kozlowski
Date: Mon Jul 29 2024 - 03:37:22 EST


On 29/07/2024 09:34, Arseniy Velikanov wrote:
> Add PWRAP clock binding and shift the following ones
>
> Fixes: eb7beb65ac30 ("clk: mediatek: add mt6765 clock IDs")

Please describe the bug and its observable impact.

> Signed-off-by: Arseniy Velikanov <me@xxxxxxxxxxxx>
> ---
> include/dt-bindings/clock/mt6765-clk.h | 131 +++++++++++++------------
> 1 file changed, 66 insertions(+), 65 deletions(-)
>
> diff --git a/include/dt-bindings/clock/mt6765-clk.h b/include/dt-bindings/clock/mt6765-clk.h
> index eb97e568518e..5d3a603a0d36 100644
> --- a/include/dt-bindings/clock/mt6765-clk.h
> +++ b/include/dt-bindings/clock/mt6765-clk.h
> @@ -161,71 +161,72 @@
> #define CLK_TOP_NR_CLK 126
>
> /* INFRACFG */
> -#define CLK_IFR_ICUSB 0

NAK, you cannot change the bindings. Especially without bigger
description where the bug is.

Best regards,
Krzysztof