Re: [PATCH] media: imx335: Fix reset-gpio handling

[Sakari Ailus]

Hi Umang,

On Mon, Jul 29, 2024 at 02:19:32PM +0530, Umang Jain wrote:
> Hi Sakari
> 
> On 29/07/24 1:11 pm, Sakari Ailus wrote:
> > Hi Umang,
> > 
> > Thanks for the patch.
> > 
> > On Mon, Jul 29, 2024 at 11:35:35AM +0530, Umang Jain wrote:
> > > The imx335 reset-gpio is initialised with GPIO_OUT_LOW during probe.
> > Should it be initialised to high instead, to enable reset?
> 
> This initialization matches the physical line status, which is low in this
> case.

Documentation/driver-api/gpio/consumer.rst:

	* GPIOD_OUT_LOW to initialize the GPIO as output with a value of 0.

...

	Note that the initial value is *logical* and the physical line
	level depends on whether the line is configured active high or
	active low (see :ref:`active_low_semantics`).

-- 
Sakari Ailus