Re: [PATCH v4 2/5] dt-bindings: net: wireless: brcm4329-fmac: add clock description for AP6275P Wi-Fi device

[Arend van Spriel]

On 7/29/2024 10:17 AM, Jacobe Zang wrote:
> > > Add clocks and clock-names for brcm4329-fmac.
> >
> > Why? Which devices have it? If only your newest addon, then squash the
> > patches and add appropriate allOf:if:then disallowing the clocks for
> > others. Or maybe all of them have it? Why commit msg does not explain
> > anything about the hardware?
>
> Alright... Becuase of the datasheet said hardware has one LPO clock input. So
> I will add allOf:if:then for this specific hardware

Maybe this can help clarifying the commit message. All Broadcom wireless 
chips have this clock input, but often the chip end up on a wifi module 
that may or may not provide the clock. From chip perspective the clock 
input is always present, but it is optional as the chip can also use an 
internal clock.

As such I would not choose to make this specific to this AP6275P 
hardware (just my 2 cents).

Regards,
Arend