Re: [PATCH net-next v25 01/13] rtase: Add support for a pci table in this module

From: Markus Elfring
Date: Mon Jul 29 2024 - 05:34:06 EST



> +++ b/drivers/net/ethernet/realtek/rtase/rtase.h
> @@ -0,0 +1,338 @@

> +#ifndef _RTASE_H_
> +#define _RTASE_H_


I suggest to omit leading underscores from such identifiers.
https://wiki.sei.cmu.edu/confluence/display/c/DCL37-C.+Do+not+declare+or+define+a+reserved+identifier

Regards,
Markus