Re: [PATCH v2 2/2] phy: qcom: add the SGMII SerDes PHY driver support

[Tengfei Fan]

On 7/9/2024 11:42 PM, Bartosz Golaszewski wrote:
> On Tue, 9 Jul 2024 at 17:16, Tengfei Fan <quic_tengfan@xxxxxxxxxxx> wrote:
> > Add the SGMII SerDes PHY driver support for QCS9100 platform.
> > QCS9100 is drived from SA8775p. Currently, both the QCS9100 and SA8775p
> > platform use non-SCMI resource. In the future, the SA8775p platform will
> > move to use SCMI resources and it will have new sa8775p-related device
> > tree. Consequently, introduce "qcom,qcs9100-dwmac-sgmii-phy" to the
> > SGMII SerDes PHY device match table.
> >
> > Signed-off-by: Tengfei Fan <quic_tengfan@xxxxxxxxxxx>
> > ---
> >   drivers/phy/qualcomm/phy-qcom-sgmii-eth.c | 1 +
> >   1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/phy/qualcomm/phy-qcom-sgmii-eth.c b/drivers/phy/qualcomm/phy-qcom-sgmii-eth.c
> > index 5b1c82459c12..0ea7140564a9 100644
> > --- a/drivers/phy/qualcomm/phy-qcom-sgmii-eth.c
> > +++ b/drivers/phy/qualcomm/phy-qcom-sgmii-eth.c
> > @@ -353,6 +353,7 @@ static int qcom_dwmac_sgmii_phy_probe(struct platform_device *pdev)
> >   }
> >
> >   static const struct of_device_id qcom_dwmac_sgmii_phy_of_match[] = {
> > +       { .compatible = "qcom,qcs9100-dwmac-sgmii-phy" },
> >          { .compatible = "qcom,sa8775p-dwmac-sgmii-phy" },
> >          { },
> >   };
> >
> > --
> > 2.25.1
>
> Reviewed-by: Bartosz Golaszewski <bartosz.golaszewski@xxxxxxxxxx

After considering the feedback provided on the subject, We have decided
to keep current SA8775p compatible and ABI compatibility in drivers.
Let's close this session and ignore all the current patches here.
Thank you for your input.

--
Thx and BRs,
Tengfei Fan