Re: [PATCH v2 0/2] PCI: qcom: Add QCS9100 PCIe compatible

[Tengfei Fan]

On 7/10/2024 6:25 PM, Aiqun Yu (Maria) wrote:
> On 7/10/2024 3:09 PM, Manivannan Sadhasivam wrote:
> > On Wed, Jul 10, 2024 at 09:47:47AM +0800, Aiqun Yu (Maria) wrote:
> > > On 7/10/2024 1:58 AM, Manivannan Sadhasivam wrote:
> > > > On Tue, Jul 09, 2024 at 10:59:28PM +0800, Tengfei Fan wrote:
> > > > > Introduce support for the QCS9100 SoC device tree (DTSI) and the
> > > > > QCS9100 RIDE board DTS. The QCS9100 is a variant of the SA8775p.
> > > > > While the QCS9100 platform is still in the early design stage, the
> > > > > QCS9100 RIDE board is identical to the SA8775p RIDE board, except it
> > > > > mounts the QCS9100 SoC instead of the SA8775p SoC.
> > > > >
> > > > > The QCS9100 SoC DTSI is directly renamed from the SA8775p SoC DTSI, and
> > > > > all the compatible strings will be updated from "SA8775p" to "QCS9100".
> > > > > The QCS9100 device tree patches will be pushed after all the device tree
> > > > > bindings and device driver patches are reviewed.
> > > >
> > > > Are you going to remove SA8775p compatible from all drivers as well?
> > >
> > > SA8775p compatible and corresponding scmi solutions for the driver will
> > > be taken care from auto team, currently IOT team is adding QCS9100
> > > support only. Auto team have a dependency on the current QCS9100(IOT
> > > non-scmi solution) and SA8775p(AUTO SCMI solution) device tree splitting
> > > effort.
> > >
> > > More background and information can be referenced from [1].
> > > [1] v1:
> > > https://lore.kernel.org/linux-arm-msm/20240703025850.2172008-1-quic_tengfan@xxxxxxxxxxx/
> >
> > I'm aware of the background, but what I don't understand is, why do you want to
> > keep the sa8775p compatible in both the driver and binding? Once you rename the
> > DT, these compatibles become meaningless.
> >
> > Waiting for Auto team to remove the compatible is not ideal. They may anyway
> > modify it based on SCMI design.
>
> Got it. Will remove sa8775p compatible in next patchset version after
> discuss with Tengfei.
>
> PCIE driver have a very good shape of resources op api, and when SCMI
> resource solution added, "sa8775p" compatible can be added at that time
> with correct SCMI resource ops.

After considering the feedback provided on the subject, We have decided
to keep current SA8775p compatible and ABI compatibility in drivers.
Let's close this session and ignore all the current patches here.
Thank you for your input.

> > - Mani
> >
> > > > - Mani
> > > >
> > > > > The final dtsi will like:
> > > > > https://lore.kernel.org/linux-arm-msm/20240703025850.2172008-3-quic_tengfan@xxxxxxxxxxx/
> > > > >
> > > > > The detailed cover letter reference:
> > > > > https://lore.kernel.org/linux-arm-msm/20240703025850.2172008-1-quic_tengfan@xxxxxxxxxxx/
> > > > >
> > > > > Signed-off-by: Tengfei Fan <quic_tengfan@xxxxxxxxxxx>
> > > > > ---
> > > > > Changes in v2:
> > > > >    - Split huge patch series into different patch series according to
> > > > >      subsytems
> > > > >    - Update patch commit message
> > > > >
> > > > > prevous disscussion here:
> > > > > [1] v1: https://lore.kernel.org/linux-arm-msm/20240703025850.2172008-1-quic_tengfan@xxxxxxxxxxx/
> > > > >
> > > > > ---
> > > > > Tengfei Fan (2):
> > > > >        dt-bindings: PCI: Document compatible for QCS9100
> > > > >        PCI: qcom: Add support for QCS9100 SoC
> > > > >
> > > > >   Documentation/devicetree/bindings/pci/qcom,pcie-sa8775p.yaml | 5 ++++-
> > > > >   drivers/pci/controller/dwc/pcie-qcom.c                       | 1 +
> > > > >   2 files changed, 5 insertions(+), 1 deletion(-)
> > > > > ---
> > > > > base-commit: 0b58e108042b0ed28a71cd7edf5175999955b233
> > > > > change-id: 20240709-add_qcs9100_pcie_compatible-ceec013a335d
> > > > >
> > > > > Best regards,
> > > > > --
> > > > > Tengfei Fan <quic_tengfan@xxxxxxxxxxx>
> > >
> > > --
> > > Thx and BRs,
> > > Aiqun(Maria) Yu

--
Thx and BRs,
Tengfei Fan