Re: [PATCH V7 0/9] SCHED_DEADLINE server infrastructure

From: Peter Zijlstra
Date: Mon Jul 29 2024 - 06:33:16 EST


On Fri, Jun 21, 2024 at 10:41:35AM -0400, Vineeth Remanan Pillai wrote:

> Sorry that I could not get to reviewing and testing this revision. In
> v6 we had experienced a minor bug where suspend/resume had issues with
> dlserver. Since suspend does not do dequeue, dlserver is not stopped
> and this causes the premature wakeups. I haven't looked at v7 in
> detail, but I think the issue might still be present.

It is not.

> We have a workaround patch for this in our 5.15 kernel

That is the problem... your necro kernel doesn't yet have the freezer
rewrite I imagine:

f5d39b020809 ("freezer,sched: Rewrite core freezer logic")

That would cause all frozen tasks to be dequeued, and once all tasks
are dequeued, the deadline server stops itself too.

Juri did some testing to double check and no suspend / resume issues
were found.

Anyway, I've merged the lot into tip/sched/core.

Thanks all!