Re: [PATCH v2 01/11] arm64: dts: qcom: sm6115-pro1x: Add Hall Switch and Camera Button

[Konrad Dybcio]

On 25.07.2024 3:42 AM, Dang Huynh wrote:
> The Pro1X has a flip keyboard and a single-state camera button.
> 
> Signed-off-by: Dang Huynh <danct12@xxxxxxxxxx>
> ---

[...]


>  
>  &tlmm {
>  	gpio-reserved-ranges = <0 4>, <14 4>;
> +
> +	hall_sensor_n: hall-sensor-n {

These must end in -state to pass binding checks (also in other
patches)

Also,

https://docs.kernel.org/devicetree/bindings/dts-coding-style.html#order-of-nodes

suggests to sort these nodes by gpio number

Konrad