Re: [PATCH v10 2/2] dmaengine: Loongson1: Add Loongson-1 APB DMA driver

[Keguang Zhang]

On Sun, Jul 28, 2024 at 5:40 PM Markus Elfring <Markus.Elfring@xxxxxx> wrote:
>
> > This patch adds …
>
> See also:
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.10#n94
>
Will drop "This patch".
>
> …
> > +++ b/drivers/dma/loongson1-apb-dma.c
> > @@ -0,0 +1,675 @@
> …
> > +static int ls1x_dma_resume(struct dma_chan *dchan)
> > +{
> …
> > +     spin_lock_irqsave(&chan->vchan.lock, flags);
> > +     ret = ls1x_dma_start(chan, &chan->curr_lli->phys);
> > +     spin_unlock_irqrestore(&chan->vchan.lock, flags);
> > +
> > +     return ret;
> > +}
> …
>
> Under which circumstances would you become interested to apply a statement
> like “guard(spinlock_irqsave)(&chan->vchan.lock);”?
> https://elixir.bootlin.com/linux/v6.10.2/source/include/linux/spinlock.h#L574
>
Will switch to guard() and scoped_guard().
Thanks!

> Regards,
> Markus



-- 
Best regards,

Keguang Zhang