Re: [PATCH net-next v25 01/13] rtase: Add support for a pci table in this module

[Andrew Lunn]

On Mon, Jul 29, 2024 at 11:33:22AM +0200, Markus Elfring wrote:
> …
> > +++ b/drivers/net/ethernet/realtek/rtase/rtase.h
> > @@ -0,0 +1,338 @@
> …
> > +#ifndef _RTASE_H_
> > +#define _RTASE_H_
> …
> 
> I suggest to omit leading underscores from such identifiers.
> https://wiki.sei.cmu.edu/confluence/display/c/DCL37-C.+Do+not+declare+or+define+a+reserved+identifier

Do you have a reference to a Linux kernel document which suggests not
to do this?

My grep foo is not great, but there appears to be around 20,000
instances of #define _[A-Z] in the kernel. So i doubt adding a couple
more is going to be an issue.

	Andrew