Re: [PATCH] perf test pmu: Remove unused test_pmus

[Ian Rogers]

On Sat, Jul 27, 2024 at 10:59 AM <linux@xxxxxxxxxxx> wrote:
>
> From: "Dr. David Alan Gilbert" <linux@xxxxxxxxxxx>
>
> Commit aa1551f299ba ("perf test pmu: Refactor format test and exposed
> test APIs") added the 'test_pmus' list, but didn't use it.
> (It seems to put them on the other_pmus list?)
>
> Remove it.
>
> Signed-off-by: Dr. David Alan Gilbert <linux@xxxxxxxxxxx>

Strange that the compiler doesn't warn about unused stuff like this,
we get unused variables within a function and unused static
functions...

Reviewed-by: Ian Rogers <irogers@xxxxxxxxxx>

Possibly:
Fixes: aa1551f299ba ("perf test pmu: Refactor format test and exposed
test APIs")

Thanks,
Ian

> ---
>  tools/perf/tests/pmu.c | 3 ---
>  1 file changed, 3 deletions(-)
>
> diff --git a/tools/perf/tests/pmu.c b/tools/perf/tests/pmu.c
> index 40132655ccd1..0b2f04a55d7b 100644
> --- a/tools/perf/tests/pmu.c
> +++ b/tools/perf/tests/pmu.c
> @@ -18,9 +18,6 @@
>  #include <sys/stat.h>
>  #include <sys/types.h>
>
> -/* Fake PMUs created in temp directory. */
> -static LIST_HEAD(test_pmus);
> -
>  /* Cleanup test PMU directory. */
>  static int test_pmu_put(const char *dir, struct perf_pmu *pmu)
>  {
> --
> 2.45.2
>