Re: [PATCH 1/4] dt-bindings: soc: qcom: smd-rpm: add generic compatible

From: Krzysztof Kozlowski
Date: Mon Jul 29 2024 - 11:02:18 EST


On 29/07/2024 13:04, Dmitry Baryshkov wrote:
> Add generic compatible to all smd-rpm devices, they follow the same
> RPMSG protocol.
>
> Fixes: bcabe1e09135 ("soc: qcom: smd-rpm: Match rpmsg channel instead of compatible")

I do not see a bug being fixed here. Whether you have fallback or not,
is a design decision with both options reasonable in certain cases.

More over, some explanation, why you are doing this or what is the
benefit, is missing.

> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx>
> ---
> .../devicetree/bindings/soc/qcom/qcom,smd-rpm.yaml | 52 +++++++++++-----------
> 1 file changed, 27 insertions(+), 25 deletions(-)


Best regards,
Krzysztof