Re: [PATCH v3 2/2] media: qcom: camss: Fix ordering of pm_runtime_enable

[Konrad Dybcio]

On 29.07.2024 2:42 PM, Bryan O'Donoghue wrote:
> pm_runtime_enable() should happen prior to vfe_get() since vfe_get() calls
> pm_runtime_resume_and_get().
> 
> This is a basic race condition that doesn't show up for most users so is
> not widely reported. If you blacklist qcom-camss in modules.d and then
> subsequently modprobe the module post-boot it is possible to reliably show
> this error up.
> 
> The kernel log for this error looks like this:
> 
> qcom-camss ac5a000.camss: Failed to power up pipeline: -13
> 
> Fixes: 02afa816dbbf ("media: camss: Add basic runtime PM support")
> Reported-by: Johan Hovold <johan+linaro@xxxxxxxxxx>
> Closes: https://lore.kernel.org/lkml/ZoVNHOTI0PKMNt4_@xxxxxxxxxxxxxxxxxxxx/
> Tested-by: Johan Hovold <johan+linaro@xxxxxxxxxx>
> Cc: <stable@xxxxxxxxxxxxxxx>
> Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@xxxxxxxxxx>
> ---

Reviewed-by: Konrad Dybcio <konradybcio@xxxxxxxxxx>

Konrad