Re: [PATCH v4] x86/paravirt: Disable virt spinlock on bare metal

From: Chen Yu
Date: Mon Jul 29 2024 - 14:48:05 EST


Hi Thomas,

On 2024-07-29 at 14:43:37 +0200, Thomas Gleixner wrote:
> On Mon, Jul 29 2024 at 14:52, Chen Yu wrote:
> > #ifdef CONFIG_PARAVIRT
> > /*
> > - * virt_spin_lock_key - enables (by default) the virt_spin_lock() hijack.
> > + * virt_spin_lock_key - disables (by default) the virt_spin_lock() hijack.
> > *
> > * Native (and PV wanting native due to vCPU pinning) should disable this key.
> > * It is done in this backwards fashion to only have a single direction change,
> > * which removes ordering between native_pv_spin_init() and HV setup.
>
> This comment is bogus now.
>

Yes, now it could be two direction: enabled first and disabled later. Let me refine
the comments.

thanks,
Chenyu