Re: [PATCH] selinux: Streamline type determination in security_compute_sid

From: Paul Moore
Date: Mon Jul 29 2024 - 16:41:12 EST


On Thu, Jul 11, 2024 at 5:10 PM Paul Moore <paul@xxxxxxxxxxxxxx> wrote:
> On Tue, Jul 2, 2024 at 10:56 PM Canfeng Guo <guocanfeng@xxxxxxxxxxxxx> wrote:
> >
> > Simplifies the logic for determining the security context type in
> > security_compute_sid, enhancing readability and efficiency.
> >
> > Consolidates default type assignment logic next to type transition
> > checks, removing redundancy and improving code flow.
> >
> > Signed-off-by: Canfeng Guo <guocanfeng@xxxxxxxxxxxxx>
> > ---
> > v2:
> > Modify the format to follow the generally accepted style for
> > multi-line comments in the Linux kernel.
> > ---
> > security/selinux/ss/services.c | 36 ++++++++++++++++++----------------
> > 1 file changed, 19 insertions(+), 17 deletions(-)
>
> Thanks for the revised patch, it looks good to me, but it is too late
> in the development cycle to merge it into the selinux/dev branch; I'm
> going to merge it into selinux/dev-staging for testing and I'll move
> it to the selinux/dev branch after the upcoming merge window closes.

A quick note to let you know that this is now in the selinux/dev branch, thanks!

--
paul-moore.com